feat: void element tags in helpers are selectable between `>` and `/>` by ddevsr · Pull Request #6717 · codeigniter4/CodeIgniter4

ddevsr · 2022-10-19T13:59:30Z

Description
Fixes #6649
Supersedes and closes #6658

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

ddevsr · 2022-10-19T14:03:30Z

@kenjis PHPStan error will be appear if changes typedoc in form_checkbox to array|string. Maybe you can fix in PR #6715

kenjis · 2022-10-19T23:36:28Z

@ddevsr Okay, I will take care of that.

I sent a PR #6721
PHPStan is correct.
Offset 'checked' on the array does not exist at the line.

kenjis · 2022-10-20T04:34:57Z

Is this a breaking change or not?
See #6658 (comment)

ddevsr · 2022-10-20T06:30:19Z

Is this a breaking change or not? See #6658 (comment)

For XHTML is breaking change, but analytics say 94,8% using HTML in 2022

See https://w3techs.com/technologies/history_overview/markup_language/ms/y

totoprayogo1916 · 2022-10-20T06:52:42Z

If only, the list here can be used for the default form_helper.

CodeIgniter4/app/Config/DocTypes.php

Lines 12 to 32 in 77e5dcf

    
           public $list = [ 
        
               'xhtml11'           => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">', 
        
               'xhtml1-strict'     => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">', 
        
               'xhtml1-trans'      => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">', 
        
               'xhtml1-frame'      => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">', 
        
               'xhtml-basic11'     => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML Basic 1.1//EN" "http://www.w3.org/TR/xhtml-basic/xhtml-basic11.dtd">', 
        
               'html5'             => '<!DOCTYPE html>', 
        
               'html4-strict'      => '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">', 
        
               'html4-trans'       => '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">', 
        
               'html4-frame'       => '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">', 
        
               'mathml1'           => '<!DOCTYPE math SYSTEM "http://www.w3.org/Math/DTD/mathml1/mathml.dtd">', 
        
               'mathml2'           => '<!DOCTYPE math PUBLIC "-//W3C//DTD MathML 2.0//EN" "http://www.w3.org/Math/DTD/mathml2/mathml2.dtd">', 
        
               'svg10'             => '<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.0//EN" "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd">', 
        
               'svg11'             => '<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">', 
        
               'svg11-basic'       => '<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Basic//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd">', 
        
               'svg11-tiny'        => '<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd">', 
        
               'xhtml-math-svg-xh' => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1 plus MathML 2.0 plus SVG 1.1//EN" "http://www.w3.org/2002/04/xhtml-math-svg/xhtml-math-svg.dtd">', 
        
               'xhtml-math-svg-sh' => '<!DOCTYPE svg:svg PUBLIC "-//W3C//DTD XHTML 1.1 plus MathML 2.0 plus SVG 1.1//EN" "http://www.w3.org/2002/04/xhtml-math-svg/xhtml-math-svg.dtd">', 
        
               'xhtml-rdfa-1'      => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML+RDFa 1.0//EN" "http://www.w3.org/MarkUp/DTD/xhtml-rdfa-1.dtd">', 
        
               'xhtml-rdfa-2'      => '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML+RDFa 1.1//EN" "http://www.w3.org/MarkUp/DTD/xhtml-rdfa-2.dtd">', 
        
           ];

kenjis · 2022-10-20T08:02:54Z

doctype([$type = 'html5'])
...
Helps you generate document type declarations, or DTD’s. HTML 5 is used by default, but many doctypes are available.
https://codeigniter4.github.io/CodeIgniter4/helpers/html_helper.html#doctype

kenjis · 2022-10-20T08:16:52Z

To begin with, HTML5 is already obsolete.
This list is only used with doctype().
Why don't we make doctype() deprecate?

ddevsr · 2022-10-21T09:58:30Z

To begin with, HTML5 is already obsolete. This list is only used with doctype(). Why don't we make doctype() deprecate?

For other HTML5, doctype() is useful and very simple

ddevsr · 2022-10-21T10:02:00Z

I already added dynamic appear HTML Tag with setting property endlineTag document type by user.

totoprayogo1916 · 2022-10-25T09:57:58Z

Btw, this also needs the same touch
Maybe in this PR or another PR

CodeIgniter4/system/Common.php

Line 279 in 1fe58f0

    
           return '<input type="hidden"' . (! empty($id) ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_token() . '" value="' . csrf_hash() . '" />';

CodeIgniter4/system/Common.php

Line 289 in 1fe58f0

    
           return '<meta' . (! empty($id) ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_header() . '" content="' . csrf_hash() . '" />';

ddevsr · 2022-10-25T12:13:31Z

Btw, this also needs the same touch Maybe in this PR or another PR

CodeIgniter4/system/Common.php

Line 279 in 1fe58f0

return '<input type="hidden"' . (! empty($id) ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_token() . '" value="' . csrf_hash() . '" />';

CodeIgniter4/system/Common.php

Line 289 in 1fe58f0

return '<meta' . (! empty($id) ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_header() . '" content="' . csrf_hash() . '" />';

Thankyou for suggest

kenjis · 2022-10-27T06:28:07Z

+     *
+     * @internal
+     */
+    function solidus(): string


How about renaming to _solidus()?
HTML helper has _get_uri().

I propose to rename it to _solidus().

This is not a normal helper function.

Now it does output a space and a solidus or empty string.

kenjis · 2022-10-27T07:01:48Z

This PR changes helpers outputs by default:

<input type="checkbox" name="foo" value="bar" />

↓

<input type="checkbox" name="foo" value="bar">

Please add it to

changelog BREAKING
https://github.com/codeigniter4/CodeIgniter4/blob/4.3/user_guide_src/source/changelogs/v4.3.0.rst#others
upgrade guide that how to keep the compatible outputs as before
https://github.com/codeigniter4/CodeIgniter4/blob/4.3/user_guide_src/source/installation/upgrade_430.rst#breaking-enhancements

kenjis

Please fix the output when using HTML5:
<input type="hidden" name="foo" value="bar" >
↓
<input type="hidden" name="foo" value="bar">

kenjis · 2022-10-30T05:47:59Z

You used git merge: 15ec83c
But please use git rebase instead to update the PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

refactor: make it valid schema html refactor: make it valid schema HTML refactor: make it valid schema HTML

Update system/Common.php Co-authored-by: kenjis <kenji.uui@gmail.com> refactor: make it valid HTML in form_helper and html_helper

paulbalandan

Can you git rebase -i and combine similar commits together? It would be hard later on debugging where to check on this git history.

paulbalandan · 2022-10-30T09:12:36Z

+if (! function_exists('solidus')) {
+    /**
+     * Generates the solidus character (`/`) depending on the HTML5 compatibility flag in `Config\DocTypes`
+     *
+     * @internal
+     */
+    function solidus(): string


Suggested change

if (! function_exists('solidus')) {

/**

* Generates the solidus character (`/`) depending on the HTML5 compatibility flag in `Config\DocTypes`

*

* @internal

*/

function solidus(): string

if (! function_exists('_solidus')) {

/**

* Generates the solidus character (`/`) depending on the HTML5 compatibility flag in `Config\DocTypes`

*

* @internal

*/

function _solidus(): string

ddevsr · 2022-10-30T11:40:43Z

Can you git rebase -i and combine similar commits together? It would be hard later on debugging where to check on this git history.

Fail rebase, how to back to commit 17d66d62cf57a46851aff15963904484c91b222e?

ddevsr · 2022-10-30T11:53:17Z

I will going with new PR

kenjis · 2022-10-30T12:12:12Z

This commit a8efae2 seems to have nothing to do with Rector error.

This commit f7bea58 has duplicated commit messages.

kenjis added the 4.3 label Oct 19, 2022

kenjis reviewed Oct 20, 2022

View reviewed changes

Comment thread tests/system/Helpers/FormHelperTest.php

kenjis mentioned this pull request Oct 20, 2022

Update closing HTML tags in form_helper.php #6658

Closed

5 tasks

kenjis reviewed Oct 20, 2022

View reviewed changes

Comment thread system/Helpers/form_helper.php Outdated

kenjis added the enhancement PRs that improve existing functionalities label Oct 22, 2022

kenjis reviewed Oct 22, 2022

View reviewed changes

Comment thread app/Config/DocTypes.php Outdated

kenjis reviewed Oct 22, 2022

View reviewed changes

Comment thread system/Common.php Outdated

kenjis reviewed Oct 22, 2022

View reviewed changes

Comment thread system/Common.php

kenjis reviewed Oct 22, 2022

View reviewed changes

Comment thread system/Common.php

kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Oct 22, 2022

kenjis reviewed Oct 23, 2022

View reviewed changes

Comment thread system/Common.php

totoprayogo1916 reviewed Oct 24, 2022

View reviewed changes

Comment thread app/Config/DocTypes.php

kenjis reviewed Oct 24, 2022

View reviewed changes

Comment thread system/Common.php

kenjis added the breaking change Pull requests that may break existing functionalities label Oct 24, 2022

kenjis changed the title ~~refactor: make it valid schema html in form_helper~~ feat: void element tags in helpers are selectable between > and /> Oct 24, 2022

paulbalandan reviewed Oct 25, 2022

View reviewed changes

Comment thread app/Config/DocTypes.php

Comment thread app/Config/DocTypes.php

ddevsr requested review from kenjis and paulbalandan October 25, 2022 09:33

paulbalandan reviewed Oct 25, 2022

View reviewed changes